Skip to content

Replaced $.browser as deprecated in jQuery 1.9#34

Open
KeithHenry wants to merge 1 commit intocowboy:masterfrom
KeithHenry:master
Open

Replaced $.browser as deprecated in jQuery 1.9#34
KeithHenry wants to merge 1 commit intocowboy:masterfrom
KeithHenry:master

Conversation

@KeithHenry
Copy link
Copy Markdown

I need to use this with jQuery 1.10, and $.browser was deprecated in jQuery 1.9.

Replaced $.browser.msie with /MSIE/.test(navigator.userAgent)

I need to use this with jQuery 1.10, and $.browser was deprecated in jQuery 1.9.

Replaced $.browser.msie with /MSIE/.test(navigator.userAgent)
@konsumer
Copy link
Copy Markdown

konsumer commented Sep 3, 2013

I think #30 is a better solution.

@KeithHenry
Copy link
Copy Markdown
Author

Ok, browser detection is bad, really you should detect features instead. The reason why is that old browsers may be patched and browsers you've never seen before may have the same issue.

Unfortunately here we're patching for specific buggy behaviour in IE6 & 7 where they can use an iframe to shim history handling - I've no idea how to test for that.

#30 is a terrible solution - it replaces $.browser.msie with !$.support.boxModel, which works because the same versions of IE (6 & 7) fail to support display: inline-block - but that's just coincidence. There's no actual relationship between $.support.boxModel and the iframe history hack working.

@williamdes
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants