Skip to content

fix: Use TARGETARCH for multi-platform builds #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aleksei Sviridkin (lexfrei) merged 2 commits into from
Feb 12, 2026
Merged

fix: Use TARGETARCH for multi-platform builds #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a33a73b
fix: Use TARGETARCH for multi-platform builds
lexfrei Feb 2, 2026
71eea82
fix: Use TARGETARCH in runtime stage for multi-platform builds
lexfrei Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
ARG FROM=alpine
FROM $FROM AS cni
ARG GOARCH=amd64
# TARGETARCH is automatically set by Docker buildx for multi-platform builds
ARG TARGETARCH
ARG GOARCH=${TARGETARCH:-amd64}

@gemini-code-assist gemini-code-assist Bot Feb 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is a good change for supporting multi-platform builds in the cni stage. However, the second stage of this Dockerfile also depends on the architecture but has not been updated. The ARG GOARCH on line 12 is declared without a value, so when using buildx it will be empty. This will cause the COPY commands on lines 20-21 to fail.

To fully enable multi-platform builds as intended, you should apply the same pattern to the second build stage by adding ARG TARGETARCH and setting ARG GOARCH=${TARGETARCH:-amd64}.

@lexfrei Aleksei Sviridkin (lexfrei) Feb 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed in 71eea82 — applied the same TARGETARCH pattern to the runtime stage.

ARG CNI_PLUGINS_VERSION=v1.1.1
RUN apk add --no-cache curl && \
curl -Lo cni.tar.gz https://github.com/containernetworking/plugins/releases/download/$CNI_PLUGINS_VERSION/cni-plugins-linux-$GOARCH-$CNI_PLUGINS_VERSION.tgz && \
tar -xf cni.tar.gz

FROM $FROM
ARG GOARCH
ARG TARGETARCH
ARG GOARCH=${TARGETARCH:-amd64}
ARG ALPINE_VERSION=v3.20
LABEL maintainer="squat <lserven@gmail.com>"
RUN echo -e "https://alpine.global.ssl.fastly.net/alpine/$ALPINE_VERSION/main\nhttps://alpine.global.ssl.fastly.net/alpine/$ALPINE_VERSION/community" > /etc/apk/repositories && \
Expand Down