Conversation
Contributor
|
We'll have to add |
DannyAntonelli
approved these changes
Nov 12, 2022
Contributor
DannyAntonelli
left a comment
DannyAntonelli
left a comment
There was a problem hiding this comment.
Tried it, liked it, approved.
Contributor
|
I think we should keep this PR as a draft and continue to push tests. If that sounds good to you, let me know so I'll start adding something. |
Member
Author
|
Sounds good to me, let's get this PR to cover tests for at least a good portion of the code before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First try at a testing setup, with the goal of having it automated on github actions eventually. WIP