fix: empty CATCH block now catches exceptions (GH #271) - #417
Open
toddr-bot wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Recreated from #347 (auto-closed when the |
An empty CATCH block (e.g., TRY; ...; CATCH; END) was silently failing to catch exceptions because Directive::try() used 'if ($default)' to check for a default handler. An empty block produces an empty string, which is falsy in Perl, so it was treated as 'no handler' and the exception propagated. Fix: change to 'if (defined $default)' to distinguish between 'no CATCH specified' (undef) and 'empty CATCH body' (empty string).
toddr-bot
force-pushed
the
koan.toddr.bot/fix-empty-catch
branch
from
July 2, 2026 23:16
9b278a2 to
fef0e07
Compare
toddr-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Empty
CATCHblocks (TRY; ...; CATCH; END) now correctly catch and suppress exceptions.Why
Directive::try()usedif ($default)to check whether a default CATCH handler existed.An empty CATCH body compiles to an empty string, which is falsy in Perl — so the handler
was silently discarded and exceptions propagated as if no CATCH was present.
How
Changed
if ($default)toif (defined $default)inDirective.pm:672. This distinguishes"no CATCH specified" (
undef) from "empty CATCH body" (''). The generated code alreadyincludes
$_tt_error = ''in the default handler block, which correctly clears the error.Testing
t/try.t: empty CATCH, empty CATCH with FINAL, empty typed CATCHwith default fallthrough, and empty CATCH with multiline TRY body.
Fixes #271
Quality Report
Changes: 2 files changed, 31 insertions(+), 1 deletion(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan