Skip to content

Update pools endpoint #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qkewq merged 3 commits into from
Jul 31, 2026
Merged

Update pools endpoint #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c247db
Update pools.go
qkewq Jul 29, 2026
1f13c5d
Update pools.go
qkewq Jul 29, 2026
9d3adda
Update pools.go
qkewq Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/proxmox/pools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ import (
func (s *ProxmoxService) GetPoolVMs(poolName string) ([]VirtualResource, error) {
req := tools.ProxmoxAPIRequest{
Method: "GET",
Endpoint: fmt.Sprintf("/pools/%s", poolName),
Endpoint: fmt.Sprintf("/pools/?poolid=%s", poolName),
}

var poolResponse struct {
var poolResponse []struct {
Members []VirtualResource `json:"members"`
}
if err := s.RequestHelper.MakeRequestAndUnmarshal(req, &poolResponse); err != nil {
Expand All @@ -28,7 +28,7 @@ func (s *ProxmoxService) GetPoolVMs(poolName string) ([]VirtualResource, error)

// Filter for VMs only (type=qemu)
var vms []VirtualResource
for _, member := range poolResponse.Members {
for _, member := range poolResponse[0].Members {
if member.Type == "qemu" {
vms = append(vms, member)
}
Expand Down Expand Up @@ -92,7 +92,7 @@ func (s *ProxmoxService) SetPoolPermission(poolName string, targetName string, i
func (s *ProxmoxService) DeletePool(poolName string) error {
req := tools.ProxmoxAPIRequest{
Method: "DELETE",
Endpoint: fmt.Sprintf("/pools/%s", poolName),
Endpoint: fmt.Sprintf("/pools/?poolid=%s", poolName),
}

_, err := s.RequestHelper.MakeRequest(req)
Expand Down
Loading