Conversation
dcbaker
force-pushed
the
submit/name-like-searches
branch
from
1c079c3 to
b450aa4
Compare
bretbrownjr
left a comment
bretbrownjr
left a comment
There was a problem hiding this comment.
I appreciate the additional test cases a lot!
I might need some time with an IDE to fully digest this change, so I'll call this a neutral set of comments.
Probably @mwoehlke-kitware should take a look too. If he wants to approve this change, don't wait on me to land. I can circle back later with my own PRs.
dcbaker
force-pushed
the
submit/name-like-searches
branch
4 times, most recently
from
179b6cb to
bb1055c
Compare
bretbrownjr
left a comment
bretbrownjr
left a comment
There was a problem hiding this comment.
Looks good to merge.
Let's make sure we circle back on the lowercase attributes and come up with a plan for TODO hygiene.
dcbaker
force-pushed
the
submit/name-like-searches
branch
from
bb1055c to
ecb82f4
Compare
|
Rebased on main, lets indeed circle back on some of the hygene stuff, I think it might be appropriate to have an issue or two around some of that in the cps-config repo |
dcbaker
force-pushed
the
submit/name-like-searches
branch
5 times, most recently
from
1219010 to
063501a
Compare
|
I've rebased on top of the other great work going on, and updated the CPS_PATH and CPS_PREFIX_PATH to match what the spec has upstream as of now. |
dcbaker
force-pushed
the
submit/name-like-searches
branch
3 times, most recently
from
7f0627c to
8acd27a
Compare
|
@dcbaker I'm just looking through the PR backlog. Is this ready to review? Can we put PRs in Draft state otherwise so I know they're not ready? |
|
I think this is ready for review |
bretbrownjr
left a comment
bretbrownjr
left a comment
There was a problem hiding this comment.
At a minimum, we'll want an intentional assertion failure or something.
bretbrownjr
left a comment
bretbrownjr
left a comment
There was a problem hiding this comment.
Mainly need:
- Error handling on undefined environment variables (i.e., nullptr handling)
- Test cases for undefined environment variables, at least to prevent crashes
- Consistent use of
CPS_CONFIG_LIBDIR_NAMEinstead ofCPS_LIBDIR - Test cases for
CPS_CONFIG_LIBDIR_NAME
dcbaker
force-pushed
the
submit/name-like-searches
branch
from
8acd27a to
0835d2b
Compare
dcbaker
force-pushed
the
submit/name-like-searches
branch
3 times, most recently
from
6d1cf3d to
fea8d32
Compare
dcbaker
force-pushed
the
submit/name-like-searches
branch
from
fea8d32 to
a21f469
Compare
This adds support for finding cps files in `$ROOT/$name/*.cps`, as well as files with capitalization.
dcbaker
force-pushed
the
submit/name-like-searches
branch
from
a21f469 to
90519ab
Compare
3 participants
With this set of changes search paths are implemented for name-like paths, this includes:
The current version has been completely rewritten from the original version of this PR, as much of the underlying problems I encountered have since been fixed by changes to the spec or by other PRs to cps-config itself.