Skip to content

more missed explicit lowercase JSON tags #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpu merged 1 commit into from
Sep 2, 2025
Merged

more missed explicit lowercase JSON tags #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions acme/client/resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ func (c *Client) Rollover(newKey crypto.Signer) error {
oldKey := keys.JWKForSigner(account.Signer)

rolloverRequest := struct {
Account string
OldKey jose.JSONWebKey
Account string `json:"account"`
OldKey jose.JSONWebKey `json:"oldKey"`
}{
Account: account.ID,
OldKey: oldKey,
Expand Down Expand Up @@ -171,7 +171,7 @@ func (c *Client) CreateOrder(order *resources.Order) error {
}

req := struct {
Identifiers []resources.Identifier
Identifiers []resources.Identifier `json:"identifiers"`
}{
Identifiers: order.Identifiers,
}
Expand Down
2 changes: 1 addition & 1 deletion shell/commands/finalize/finalize.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func finalizeHandler(c *ishell.Context) {
}

finalizeRequest := struct {
CSR string
CSR string `json:"csr"`
}{
CSR: b64csr,
}
Expand Down
2 changes: 1 addition & 1 deletion shell/commands/getAcct/getAcct.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func getAccountHandler(c *ishell.Context) {
client := commands.GetClient(c)

getAcctReq := struct {
OnlyReturnExisting bool
OnlyReturnExisting bool `json:"onlyReturnExisting"`
}{
OnlyReturnExisting: true,
}
Expand Down
4 changes: 2 additions & 2 deletions shell/commands/revokeCert/revokeCert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ func revokeCertHandler(c *ishell.Context) {
certBytes := pemBlock.Bytes

revokeRequest := struct {
Certificate string
Reason int
Certificate string `json:"certificate"`
Reason int `json:"reason"`
}{
Certificate: base64.RawURLEncoding.EncodeToString(certBytes),
Reason: opts.reason,
Expand Down
Loading