Move SDK DOM progress indicator into the app (#231) - #350
Open
yunus-dev-codecrafter wants to merge 1 commit into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #231
What changed
Moved the SDK's imperative DOM-based progress indicator out of the headless
@sharibo/clientand rebuilt it as a React component (app/src/components/ArtifactProgress.tsx) that subscribes to the existingsubscribeToArtifactPrefetchAPI, announces progress through the app's sharedusePoliteLiveRegionhook, and renders a token-styled progress bar. Also deleted theinstallIndicator/updateIndicatorDOM code, exported the subscription API surface, and resolved a pre-existingprefers-reduced-motionmerge conflict instyle.css.Why
Closes #231
The SDK's
packages/client/src/artifacts.tshand-built a DOM node (hardcoded colors, its ownaria-liveregion, fixed positioning) inside an otherwise headless SDK, so it couldn't follow the app's theme, respectprefers-reduced-motion, or be positioned by the app. Moving the indicator into the app makes the SDK fully headless and reuses the app's single live region.Testing
cd circuits && npm test)cd contracts && cargo test)npm run e2e)cd app && npm test src/components/ArtifactProgress.test.tsx— 3 passing)document.references; exactly onearia-liveregion in the rendered app)Screenshots
The progress bar now renders inside the app card using existing design tokens (
--accent2,var(--border), JetBrains Mono), showing "Preparing prover… N%" with an animated fill; it hides automatically once artifacts are ready.