Test the artifact prefetch progress reporting - #352
Open
probablyABug wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removed the import-time artifact prefetch side effect so the client artifact module can be tested without triggering real network requests. Added deterministic tests covering streamed download progress, missing
content-lengthhandling, concurrent prefetch calls, error propagation, and progress subscriptions.Why
Closes #321
The artifact prefetch logic previously had no test coverage and could not be imported safely in tests because importing the module triggered a real fetch. These changes make the behavior independently testable and verify that progress reporting, concurrent request sharing, subscriptions, and download failures behave as expected.
Testing
cd circuits && npm test)cd contracts && cargo test)npm run e2e)cd app && npm run dev)Screenshots
Not applicable — no app UI changes.