Show per-member claim eligibility using has_claimed (#312) - #369
Open
ositaemmanuel653-netizen wants to merge 1 commit into
Open
Conversation
- Call has_claimed as read-only - Pre-check per-member nullifier on entering claim step - Mark ineligible members and disable selection - Add ineligible flag to Member type - Update MemberRing/ClaimSection UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #312
What changed
has_claimedas a read-only contract simulation instead of submitting a transaction.ineligibleflag to theMembertype.MemberRingandClaimSectionto reflect per-member claim eligibility.Why
Closes #312
The app previously allowed users to select a member who had already claimed, only discovering the issue after generating a proof and attempting the claim. Since proof generation is the slowest part of the flow, checking eligibility before proving provides immediate feedback and avoids unnecessary proof generation and failed transactions.
The
has_claimedcontract method is now used as a read-only simulation so eligibility checks do not submit transactions or incur transaction costs.Testing
cd circuits && npm test)cd contracts && cargo test)npm run e2e)cd app && npm run dev)Screenshots
Before
After