Batch document sync jobs#70
Open
timkelty wants to merge 1 commit into
Open
Conversation
timkelty
force-pushed
the
timkelty/fix-batched-document-sync
branch
from
4af1399 to
1f62dad
Compare
|
Thank you for the notes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves document sync onto Craft's batched queue job contract so large indexes can progress across spawned jobs without losing stale-document cleanup state.
Based on v5...imarc:craft-typesense:v5, but fixing some issues (cc @LinneaImarc)
loadData(). SinceBaseBatchedJobreloads data for spawned batches, a flush job could delete/recreate the collection again on later batches.$upsertIds, which won’t survive queue serialization between spawned jobs. That makes stale cleanup only aware of the final batch.loadData()returns aBatchableon missing client/collection paths.