fix: support shell args, tilde, user PATH for local connections#4
Merged
Merged
Conversation
The Connection profile's shell field went straight to portable_pty's CommandBuilder, so entries like \`screen.sh 2\` were treated as a single binary name (whitespace included) and \`~/...\` paths were never expanded since OS exec doesn't do shell expansion. GUI-launched apps also inherit a stripped PATH that omits user bin dirs, so bare \`screen.sh\` couldn't be resolved either. - whitespace-split the shell field into program + args (no quote support yet — \`a "b c"\` becomes 3 tokens) - expand leading ~/ and bare ~ via \$HOME for program, args, and cwd - prepend \$HOME/.local/bin and \$HOME/bin to PATH if missing - show the local-connection error panel with a plain Reconnect button instead of the SSH \`@:22\` password form Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The sessionId-resize createEffect added in the merged \"sync PTY size on connect\" change reads the \`term\` ref directly. SolidJS schedules effects to run after the component body but before onMount callbacks, so when the tab is auto-reconnected from saved state the effect's first pass sees \`term\` undefined, bails, and never re-fires (term isn't reactive). Net result: the PTY stays at the placeholder 80x24. Gate the effect on a \`termReady\` signal flipped at the end of onMount so it re-runs once \`term\` is actually wired up. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Connection profile's shell field went straight to portable_pty's CommandBuilder, so entries like `screen.sh 2` were treated as a single binary name (whitespace included) and `~/...` paths were never expanded since OS exec doesn't do shell expansion. GUI-launched apps also inherit a stripped PATH that omits user bin dirs, so bare `screen.sh` couldn't be resolved either.