fixed print.summary Pr(>|z|) vs. Pr(>|t|) problem#1
Open
jcfisher wants to merge 1 commit into
Open
Conversation
summary.speedglm produces an object whose last column is always a p-value, but sometimes it is named Pr(>|t|) and sometimes it is named Pr(>|z|). This causes an error with cbind, causing the print to fail. I fixed it by telling it to use the last column of x$coefficients, x$coefficients[, ncol(x$coefficients)].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary.speedglm produces an object whose last column is always a p-value, but sometimes it is named Pr(>|t|) and sometimes it is named Pr(>|z|). This causes an error with cbind in print.summary.speedglm (line 94), which causes the print to fail. I fixed it by telling it to use the last column of x$coefficients, x$coefficients[, ncol(x$coefficients)].