fix(apache): remove NULL-returning create_dir_config/merge_dir_config stubs (#96)#154
Merged
Merged
Conversation
… stubs Both dir-config callbacks returned NULL while being registered as non-NULL function pointers. This creates a latent NULL-deref risk for any code calling ap_get_module_config(r->per_dir_config, ...). Since all directives are RSRC_CONF (server-level only), set both slots to NULL in the module struct instead — Apache's convention for modules with no per-directory config. Closes #96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_dir_configandmerge_dir_configstub functions that returnedNULLwhile being registered as non-NULL function pointersNULLin themesi_modulestruct — Apache's standard convention for modules with no per-directory configurationap_get_module_config(r->per_dir_config, ...)Closes #96