[core] Implement <esi:choose>, <esi:when>, <esi:otherwise> (#162)#269
Merged
Conversation
Implement conditional content selection for ESI: - <esi:choose> with <esi:when test="..."> branches - <esi:otherwise> fallback - Boolean literal evaluation (true/false/0/1) - variable resolution in test expressions - Nested choose, try, include, and vars inside branches - Depth-aware block extraction with proper nesting support Adds 20+ unit tests covering all acceptance criteria and an e2e fixture. Updates feature matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements conditional content selection via
<esi:choose>,<esi:when>, and<esi:otherwise>elements in the core ESI parser.Closes #162
Changes
evaluateTest(),extractChooseBlocks(),processChooseBlock(), and depth-aware helper functions for parsing nested choose/when/otherwise blocksImplementation details
testexpressions (true/false/0/1)$(...)variable resolution intestattributes<esi:choose>)<esi:try>(both attempt and except blocks)Test coverage
test="true"→ renders when bodytest="false"→ renders otherwise$(VAR)resolution in test