upgrade Go version to 1.25 and update dependencies - #2
Conversation
WalkthroughBumped Go to 1.25 across CI and module, updated GitHub Actions versions in build, docker, and release workflows, and upgraded multiple Go module dependencies in go.mod. No logic, control flow, or exported/public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.2.2)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/product/migration-guide for migration instructions ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
=======================================
Coverage 50.70% 50.70%
=======================================
Files 15 15
Lines 1992 1992
=======================================
Hits 1010 1010
Misses 847 847
Partials 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (8)
.github/workflows/docker.yml (2)
26-26: Prefer an explicit minor.x or caret range over “~1.25”, and quote itsetup-go supports exact versions and SemVer ranges like ^ and >=. “~” isn’t documented; use '1.25.x' or '^1.25.0' and wrap in quotes to avoid YAML pitfalls.
Apply within this step:- go-version: ~1.25 + go-version: '1.25.x'Refs. setup-go docs on supported syntax and quoting. (github.com)
9-11: Add least-privilege permissions and a concurrency gateReduce token blast radius and avoid overlapping weekly runs.
Outside the shown lines, add at job level:permissions: contents: read concurrency: group: docker-rebuild cancel-in-progress: falseGitHub recommends declaring minimal permissions explicitly. (github.blog)
.github/workflows/build.yaml (2)
16-16: Matrix Go version: consider '1.25.x' to ensure latest patchThis avoids stale cached patches without needing check-latest.
- go_version: ['1.25'] + go_version: ['1.25.x']Supported version forms per setup-go. (github.com)
41-45: Codecov v5 migration: input name is correct; optionally switch to OIDCfiles input is correct for v5; consider OIDC auth to drop repo token in public repos (set permissions id-token: write and use use_oidc: true).
- uses: codecov/codecov-action@v5 + uses: codecov/codecov-action@v5 with: env_vars: OS,GO files: ./coverage.out flags: unittests fail_ci_if_error: false verbose: true - token: ${{ secrets.CODECOV_TOKEN }} + use_oidc: true +permissions: + id-token: writeCodecov v5 deprecates file→files; supports OIDC. (github.com)
.github/workflows/release.yml (3)
22-22: Use '1.25.x' (or '^1.25.0') and quote it“~” isn’t in the documented setup-go range syntax; prefer a documented form and quote to avoid YAML surprises.
- go-version: ~1.25 + go-version: '1.25.x'Refs. setup-go docs. (github.com)
9-12: Explicit permissions for GoReleaserGoReleaser typically needs contents: write for tagging/releases. Add minimal permissions at the job level.
permissions: contents: writeGitHub recommends declaring least-privilege permissions. (github.blog)
16-18: Drop Unshallow by fetching full history in checkoutSlight simplification and one less git call.
- - name: Unshallow - run: git fetch --prune --unshallow + - name: Checkout + uses: actions/checkout@v5 + with: + fetch-depth: 0go.mod (1)
3-3: Go 1.25 target confirmedGo 1.25 was released on August 12, 2025; upgrade aligns with CI.
Optional: decide whether you want 'go 1.25' or 'go 1.25.0'—since Go 1.21, patch-level in the go directive is supported and used by tooling, but it does set a stricter minimum. (go.dev, github.com)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
.github/workflows/build.yaml(2 hunks).github/workflows/docker.yml(2 hunks).github/workflows/release.yml(1 hunks)go.mod(2 hunks)
🔇 Additional comments (5)
.github/workflows/docker.yml (1)
13-13: Checkout v5 upgrade looks goodUp-to-date with Actions’ Node 20 runtime. (github.blog)
.github/workflows/build.yaml (1)
22-22: Checkout v5 is aligned with current runnersNice bump; compatible with Node 20-based runners. (github.blog)
.github/workflows/release.yml (1)
14-14: Checkout v5 upgrade looks goodMatches current Actions runtime. (github.blog)
go.mod (2)
14-15: bbolt v1.4.x bump is validv1.4.3 exists upstream; good to pick latest in that series. (github.com)
15-16: x/net, x/time bumps: enable cgo for race‐detector sweepQuick sanity check across Linux, Windows, and Darwin with the race detector. From the repo root, run:
#!/bin/bash set -euo pipefail for os in linux windows darwin; do CGO_ENABLED=1 GOOS=$os GOARCH=amd64 go vet ./... CGO_ENABLED=1 GOOS=$os GOARCH=amd64 go test -race ./... done
1 participant
upgrade Go version to 1.25 and update dependencies in workflow files and go.mod
Summary by CodeRabbit