Skip to content

fix: demo mode sessionStorage check independent of Clerk isUserLoaded - #87

Merged
rprabhat merged 1 commit into
mainfrom
fix/demo-mode-sessionstorage
Jun 12, 2026
Merged

fix: demo mode sessionStorage check independent of Clerk isUserLoaded#87
rprabhat merged 1 commit into
mainfrom
fix/demo-mode-sessionstorage

Conversation

@rprabhat

Copy link
Copy Markdown
Collaborator

Root Cause: The demo sessionStorage check was gated behind Clerk's isUserLoaded flag. When Clerk publishableKey is empty (production), Clerk's useUser().isLoaded never becomes true, so fetchTenantInfo was never called — meaning demo sessionStorage data was never detected.

Fix: Extract the demo sessionStorage check outside the if (isUserLoaded) guard. Demo detection now runs immediately on every render, before any Clerk-dependent code.

Verification:

  • Demo flow: POST /api/demo → POST /api/demo/login → /demo-login stores sessionStorage → /roster reads sessionStorage (independent of Clerk)
  • Non-demo path unchanged: still waits for isUserLoaded before calling Clerk-dependent TenantInfo fetch

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
crew-roster Building Building Preview, Comment Jun 12, 2026 6:41am

@rprabhat
rprabhat merged commit 99f3570 into main Jun 12, 2026
3 of 5 checks passed
@rprabhat
rprabhat deleted the fix/demo-mode-sessionstorage branch June 12, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants