feat: architecture improvements - #96
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ervice, add timesheets feature, vitest - RosterGrid: 775→354 lines (-54%), extracted ShiftCreationModal, useAutoSaveRoster, useRosterDragAndDrop - rosterStore: extracted rosterApi.ts (8 typed operations), store now pure state - validators: removed duplicate web-local, wired @packages/validators workspace dep - timesheets: new feature module with hooks + components (259→4 lines page wrapper) - Neon client: removed dead query() function - vitest: added config with jsdom, testing-library, mocks for Clerk/Next.js/Zustand - tests: rosterApi.test.ts (15 tests covering all 8 API functions) - migrations: superseded 20240001_core_schema.sql by 20260328 version - C4 diagrams updated, gap-analysis.md updated
- useAutoSaveRoster: fix useRef type, filter shifts with valid ids - useRosterDragAndDrop: use any for sensor return types - useTimesheets: use isLoading from useAuth (not authLoading) - TimesheetsPage: remove unused imports - vitest.config: remove @vitejs/plugin-react (peer dep conflict) - vitest.setup: fix zustand create mock type - packages/validators: add root export for @packages/validators - apps/web/package.json: add @vitejs/plugin-react (later removed) - lint: skip e2e in root eslint config
rprabhat
force-pushed
the
feat/architecture-improvements
branch
from
June 21, 2026 08:55
e4d33d2 to
1833a1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements deepening opportunities identified in the architecture review:
Changes
RosterGrid decomposition (775-354 lines, -54%)
RosterStore API extraction
Validator cleanup
Timesheets feature module (new)
Neon client cleanup
Vitest test infrastructure
Migration cleanup
Documentation
Testing
Compliance