fix: accuracy scorer checks section field, not just citation label - #44
Merged
Conversation
…label Found via q09 of the production-path benchmark: retrieval hit exactly the right section (heading breadcrumb "...Section 25-35 (Bad debts)" in the citation dict's `section` field, an exact match for the expected "ITAA 1997 s.25-35"), but the citation LABEL stayed a bare "ITAA 1997" - score_answer only ever read `citation`, never the richer `section` field hierarchical chunking already populates. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while writing a detailed failure analysis of the production-path benchmark: q09 (bad debt deduction question) retrieved exactly the right section — the citation dict's
sectionfield read"...Section 25-35 (Bad debts)", an exact match for the expected"ITAA 1997 s.25-35"— but the citation LABEL stayed a bare"ITAA 1997".score_answer()only ever checkedcitation, never the richersectionfield hierarchical chunking already populates, so a perfectly-grounded answer scoredcit_ratio=0.Extends the existing section/division-token loosened match (from #43) to also check against the
sectionfield alongside the citation label and answer text.Test plan