Bug/update to proto v5#50
Open
pw42020 wants to merge 3 commits into
Open
Conversation
…ys_print_fields_with_no_presence so both versions of protobuf are supported
|
@crflynn Hello, we tested and it works for us (protobuf-6.33.0). could you merge it and release new version? Thanks a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added
always_print_fields_with_no_presencefield_proto.pyto have bothincluding_default_value_fieldsandalways_print_fields_with_no_presenceso both versions of protobuf are supportedalways_print_fields_with_no_presencefieldRemoved
testforincluding_default_value_fieldsIssue ticket number and link
!49
Checklist before requesting a review