Add WithService() methods to gsheets, gdrive#11
Open
connor15mcc wants to merge 1 commit intocristoper:masterfrom
Open
Add WithService() methods to gsheets, gdrive#11connor15mcc wants to merge 1 commit intocristoper:masterfrom
WithService() methods to gsheets, gdrive#11connor15mcc wants to merge 1 commit intocristoper:masterfrom
Conversation
This allows consumers of this (very nifty!) package to override the service and provide their own (vs the default). Useful when using custom options (ex specifying a credentials file or different transport). An alternative would be to take the service as an argument to existing constructor (breaking change, did not consider) or to add make the internal interface public (not pursued since that interface is private and I thought it odd to leak). This change does **not** impact CLI usage and only expands the functionality as a go package.
connor15mcc
force-pushed
the
client-options
branch
from
79f4ff7 to
98aa722
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 LMK if you prefer a different mechanism for patches :)
This allows consumers of this (very nifty!) package to override the
service and provide their own (vs the default). Useful when using custom
options (ex specifying a credentials file or different transport).
An alternative would be to take the service as an argument to existing
constructor (breaking change, did not consider) or to add make the
internal interface public (not pursued since that interface is private
and I thought it odd to leak).
This change does not impact CLI usage and only expands the
functionality as a go package.