Add Node.js version validation for HTML package builds#612
Add Node.js version validation for HTML package builds#612Copilot wants to merge 2 commits intodevelopmentfrom
Conversation
|
@m-s- @pedroapap please review. It looks good to me |
|
@copilot rebase with development. and please follow our commit guidelines |
Rebased with development branch (cea36c60) and reformatted commits to follow conventional commit guidelines:
The branch is now based on the latest development commit (2e60db9) with a single properly formatted conventional commit. |
a285c50 to
abd1f36
Compare
|
@copilot tests are throwing Object reference not set to an instance of an object. |
Fixed in cdcf40b. The NullReferenceException occurred because the HTML handlers were accessing Added null safety checks to both Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Add null safety checks when accessing ExecutionContext.Instance and ServiceProvider in HTML package handler constructors to prevent NullReferenceException during test execution. Co-authored-by: joaoopereira <3718704+joaoopereira@users.noreply.github.com>
cdcf40b to
b0aeb2d
Compare
Add Node.js version validation for HTML package builds
This PR implements validation to ensure the installed Node.js version is compatible with the target MES version when building HTML packages.
Changes
NodeVersionUtilities: Detects installed Node.js version via
node --versionand validates compatibility against required version fromDependencyVersionServiceError messages: Added
NodeNotInstalledandIncompatibleNodeVersionwith links to installation documentationHandler validation: Both
HtmlNgCliPackageTypeHandlerandHtmlGulpPackageTypeHandlernow validate Node.js version in constructor before build steps execute (with null safety checks for test compatibility)Tests: Coverage for version detection and validation logic across MES versions
Example
With Node.js v18 installed, attempting to build an MES 11 HTML package now fails early with:
Updates
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.