Bugfix: VTT notes not displaying on GCS Actor Sheet#2736
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes #2680 by restoring display/edit support for “VTT Notes” (often containing OTF) in the v1.0.0 item UI/data flow.
Changes:
- Renames the item system field from
vtt_notestovttNotesacross templates, adapters, importers, and i18n keys. - Updates
BaseItemModel.toDisplayItem()to include VTT notes when generating the renderednotesHTML. - Updates multiple translations to match the new
vttNoteskey.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| static/templates/item/partials/details-base.hbs | Uses system.vttNotes / systemFields.vttNotes in the item details form. |
| static/lang/en.json | Renames translation key from vtt_notes to vttNotes. |
| static/lang/de.json | Renames translation key from vtt_notes to vttNotes. |
| static/lang/fr.json | Renames translation key from vtt_notes to vttNotes. |
| static/lang/pt_br.json | Renames translation key from vtt_notes to vttNotes. |
| static/lang/ru.json | Renames translation key from vtt_notes to vttNotes. |
| src/module/item/legacy/trait-adapter.ts | Reads VTT notes from system.vttNotes when composing legacy notes. |
| src/module/item/legacy/spell-adapter.ts | Reads VTT notes from system.vttNotes when composing legacy notes. |
| src/module/item/legacy/skill-adapter.ts | Reads VTT notes from system.vttNotes when composing legacy notes. |
| src/module/item/legacy/equipment-adapter.ts | Reads VTT notes from system.vttNotes when composing legacy notes. |
| src/module/item/data/base.ts | Adds VTT notes into toDisplayItem() output and renames schema field to vttNotes. |
| src/module/importer/gcs-importer/importer.ts | Maps GCS vtt_notes input into system.vttNotes. |
| src/module/importer/gca-importer/importer.ts | Maps GCA vttnotes input into system.vttNotes. |
rinickolous
changed the title
mjeffw
approved these changes
May 29, 2026
|
|
||
| /** VTT-specific notes about this item, not visible in external programs but useful for storing OTF and the like. */ | ||
| vtt_notes: new fields.StringField({ required: true, nullable: true, initial: null }), | ||
| vttNotes: new fields.StringField({ required: true, nullable: true, initial: null }), |
Comment on lines
+377
to
+383
| let unformattedNotes = this.notes.trim() | ||
|
|
||
| if (unformattedNotes.length > 0) unformattedNotes += '\n' | ||
|
|
||
| const vttNotesTrimmed = this.vttNotes?.trim() ?? '' | ||
|
|
||
| unformattedNotes += vttNotesTrimmed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2680