fix: add missing item finding functionality to CharacterModel (#2685)

[rinickolous]

Fixes #2685

[Copilot]

Pull request overview

This PR fixes the broken global item-finding helpers (GURPS.findSkill, GURPS.findAdDisad, GURPS.findAttack, etc.) by routing lookups through CharacterModel (and a small adapter) instead of calling methods directly on the Actor document, addressing #2685.

Changes:

• Added src/module/util/find-item.ts to resolve an Actor document to a CharacterModel and provide findSkill/findSpell/findSkillSpell/findAdDisad/findAttack helpers.
• Implemented skill/spell lookup methods on CharacterModel (regex-based, best-level selection per list).
• Updated src/module/gurps.js to expose these helpers on the GURPS global and use them in OTF “test-exists” handling.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/module/util/find-item.ts	New adapter/helper module that resolves Actor→CharacterModel and exposes item-finding functions used by GURPS.*.
src/module/gurps.js	Wires the new helpers into the GURPS global API and replaces removed in-file implementations.
src/module/actor/data/character.ts	Adds CharacterModel lookup methods for skills/spells (and a shared regex builder) used by the new global helpers.

Comments suppressed due to low confidence (1)

src/module/util/find-item.ts:26

• New item-finding behavior is introduced via find-item.ts and the new CharacterModel lookup methods, but there are no unit tests covering the key cases that caused #2685 (passing an Actor document vs actor.system, and handling null/undefined actor inputs). Adding a small Vitest suite for these helpers would help prevent regressions in global APIs like GURPS.findSkill/findAttack.

export function findSkill(actor: CharacterOrActor, name: string): Item.OfType<ItemType.Skill> | null {
  return resolveCharacterModel(actor)?.findSkill(name) ?? null
}

/* ---------------------------------------- */

export function findSpell(actor: CharacterOrActor, name: string): Item.OfType<ItemType.Spell> | null {
  return resolveCharacterModel(actor)?.findSpell(name) ?? null
}

[mjeffw]

Module utils should add these methods to the GURPS global in its init() method.