Skip to content

fix: sanitize colon in container name for tag+digest package refs #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcogilvie merged 1 commit into from
May 5, 2026
+6 −2
Merged

fix: sanitize colon in container name for tag+digest package refs #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/diff/diffprocessor/function_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,8 @@ func generateContainerName(pkg, instanceID string) string {
// Handle SHA256 digest references: name@sha256:digest
// Extract just the function name and a truncated digest
if before, after, ok := strings.Cut(nameAndVersion, "@sha256:"); ok {
funcName := before
digest := after // Skip "@sha256:"
funcName := strings.ReplaceAll(before, ":", "-")
digest := after

// Use first 12 chars of digest (like Docker short image IDs)
if len(digest) > 12 {
Expand Down
4 changes: 4 additions & 0 deletions cmd/diff/diffprocessor/function_provider_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,10 @@ func TestGenerateContainerName(t *testing.T) {
pkg: "xpkg.io/test/function@sha256:abc123",
want: "function-abc123-comp-test1234",
},
"TagAndDigest": {
pkg: "registry.io/path/function-auto-ready:v0.6.1-0@sha256:751a4afb65f1abcdef1234567890abcdef1234567890abcdef1234567890abcd",
want: "function-auto-ready-v0.6.1-0-751a4afb65f1-comp-test1234",
},
}

for name, tt := range tests {
Expand Down
Loading