feat: Add Crossview favicon to browser tab#269
Merged
MoeidHeidari merged 3 commits intoMay 27, 2026
Conversation
…-release chore(release): merge pre-release into main for v4.4.0
Replace the default Vite favicon with the Crossview logo SVG. The logo already existed at public/images/crossview-logo.svg — this change wires it up in index.html so the app icon appears correctly in browser tabs and bookmarks when running locally or in production. Signed-off-by: mdischner <57560890+mdischner@users.noreply.github.com>
Switch from crossview-logo.svg (which includes text) to cross-view-logo-sidebar.svg, which contains only the icon mark. This renders correctly at small favicon sizes in browser tabs. Signed-off-by: mdischner <57560890+mdischner@users.noreply.github.com>
mdischner
force-pushed
the
feat/add-favicon
branch
from
8b60432 to
3ea3a5c
Compare
mdischner
changed the title
Author
|
@MoeidHeidari ready for your review ;) |
Collaborator
Sure. thanks for your contribution. The change looks good to me. Just a tiny request. Please change the target branch to pre-release in stead of main. we collect changes there to be included in the new release candidate. |
Author
|
HI @MoeidHeidari, thanks for pointing it out. Done! |
Collaborator
|
Nice @mdischner, that is great. will merge it then. |
MoeidHeidari
merged commit dc07f2b
into
crossplane-contrib:pre-release
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/vite.svg) with the Crossview logo SVG that already exists in the repository atpublic/images/crossview-logo.svgindex.htmlMotivation
When deploying the service locally (or in production), the browser tab shows the generic Vite logo instead of the Crossview branding. This fix wires up the existing logo asset so the correct icon appears in browser tabs, bookmarks, and pinned tabs.
Changes
index.html: Update<link rel="icon">href from/vite.svgto/images/crossview-logo.svgNo new assets were added — the SVG was already part of the repository.