Bump to crossplane v2 by phisco · Pull Request #98 · crossplane-contrib/function-environment-configs

phisco · 2026-02-13T12:09:01Z

Description of your changes

This PR brings function-environment-configs to the current Crossplane v2 / function-template-go baseline and removes deprecated function-sdk-go usage.

What changed:

Aligned repo/tooling baseline with function-template-go.
Upgraded dependencies to function-sdk-go v0.5.0 and aligned related module pins.
Migrated runtime imports to crossplane-runtime/v2.
Synced CI workflow to template conventions (actions versions, build/push flow, tool versions) and removed the old tag.yml workflow.
Synced renovate.json and .golangci.yml to template baseline.
Updated package metadata to Crossplane v2 constraint and kept project annotations.
Added function capabilities declaration in package metadata:
- spec.capabilities: [composition]

Deprecated SDK cleanup (strict new field usage):

request.GetExtraResources -> request.GetRequiredResources
Requirements.ExtraResources -> Requirements.Resources
resource.Extra -> resource.Required
Updated function logic and tests accordingly.

Testing performed:

GOTOOLCHAIN=go1.24.9 go mod tidy
GOTOOLCHAIN=go1.24.9 GOCACHE=/tmp/go-build go test ./...

Fixes #

I have:

Read and followed Crossplane's contribution process.
Added or updated unit tests for my change.

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

Copilot

Pull request overview

This PR updates function-environment-configs to the Crossplane v2 baseline by migrating imports to crossplane-runtime/v2, upgrading to function-sdk-go v0.5.0, and aligning CI/tooling metadata with the function-template-go conventions.

Changes:

Upgraded Go module dependencies and migrated Crossplane runtime imports to crossplane-runtime/v2 (including SDK-required resource field migrations).
Updated Function package metadata to require Crossplane v2 and declare composition capability.
Synced CI, golangci-lint, and Renovate configuration to the current template baseline; removed the legacy tag workflow.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
renovate.json	Aligns Renovate config with template baseline and adds Go module post-update options.
package/crossplane.yaml	Bumps Crossplane version constraint to v2 and declares function capabilities.
main.go	Reorders/edits CLI struct tags.
input/v1beta1/zz_generated.deepcopy.go	Updates generated imports to `crossplane-runtime/v2`.
input/v1beta1/composition_environment.go	Migrates runtime imports to `crossplane-runtime/v2` and tidies formatting.
go.mod	Updates module Go version and bumps core dependencies (Crossplane runtime v2, function SDK v0.5.0, k8s libs, etc.).
go.sum	Refreshes dependency checksums after module upgrades.
fn.go	Migrates deprecated SDK “extra resources” usage to “required resources”; refactors sorting comparator helpers; updates map typings to `any`.
fn_test.go	Updates tests to the new SDK required-resources APIs and updated runtime imports.
README.md	Updates documented minimum Crossplane version to 2.0+.
Dockerfile	Adds guidance about CGO/glibc implications.
.golangci.yml	Syncs golangci-lint configuration to template baseline and enables additional formatters.
.github/workflows/tag.yml	Removes deprecated manual tag workflow.
.github/workflows/ci.yml	Updates CI tool/action versions and adjusts build/push flow to template conventions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-13T14:30:43Z

fn.go

-	extraResources, err := request.GetExtraResources(req)
+	requiredResources, err := request.GetRequiredResources(req)
 	if err != nil {
 		response.Fatal(rsp, errors.Wrapf(err, "cannot get Function input from %T", req))


This Wrapf message refers to getting "Function input" but this code path is parsing required resources. Updating the message to mention required resources will make fatal errors easier to understand when debugging failures.

Suggested change

response.Fatal(rsp, errors.Wrapf(err, "cannot get Function input from %T", req))

response.Fatal(rsp, errors.Wrapf(err, "cannot get required resources from %T", req))

Copilot · 2026-02-13T14:30:44Z

fn.go

@@ -203,24 +205,24 @@ func processSourceByReference(in *v1beta1.Input, config v1beta1.EnvironmentSourc
 		return nil, errors.Errorf("Required environment config %q not found", envConfigName)


Go error strings should typically start with a lowercase letter and avoid capitalized words at the beginning. Consider changing this to start with "required" (and keep phrasing consistent with the other errors in this file).

Suggested change

return nil, errors.Errorf("Required environment config %q not found", envConfigName)

return nil, errors.Errorf("required environment config %q not found", envConfigName)

Copilot · 2026-02-13T14:30:44Z

fn.go

+	case reflect.String:
+		return lessAs[string](a, b)
+	default:
+		return false, errors.Errorf("unsupported type %q for sorting", kind)


%q is a confusing verb for reflect.Kind here (it will quote a rune / may not render the kind name as intended). Prefer %s (using kind.String()) or %v so the error message clearly states the unsupported kind.

Suggested change

return false, errors.Errorf("unsupported type %q for sorting", kind)

return false, errors.Errorf("unsupported type %v for sorting", kind)

Copilot · 2026-02-13T14:30:44Z

.github/workflows/ci.yml

-      packages: write
+    runs-on: ubuntu-24.04
    needs:
      - build


The push job performs a registry login and pushes packages to GHCR, but it doesn't declare explicit permissions. Pushing to GHCR typically requires packages: write (and contents: read for checkout); relying on repo defaults can make the workflow fail in repos where the GITHUB_TOKEN default is read-only.

Suggested change

- build

- build

permissions:

contents: read

packages: write

Copilot · 2026-02-13T14:30:45Z

main.go

+	Network            string `default:"tcp"                                                                                        help:"Network on which to listen for gRPC connections."`
+	Address            string `default:":9443"                                                                                      help:"Address at which to listen for gRPC connections."`
+	TLSCertsDir        string `env:"TLS_SERVER_CERTS_DIR"                                                                           help:"Directory containing server certs (tls.key, tls.crt) and the CA used to verify client certificates (ca.crt)"`
 	Insecure           bool   `help:"Run without mTLS credentials. If you supply this flag --tls-server-certs-dir will be ignored."`
-	MaxRecvMessageSize int    `help:"Maximum size of received messages in MB." default:"4"`
+	MaxRecvMessageSize int    `default:"4"                                                                                          help:"Maximum size of received messages in MB."`


The excessive whitespace inside these struct tags makes them hard to read and easy to accidentally alter (even though it still parses). Consider removing the manual alignment and using normal tag formatting (e.g., help:"..." default:"..." env:"...") to keep diffs and maintenance sane.

Copilot · 2026-02-13T14:30:45Z

go.mod

-go 1.23
-
-toolchain go1.24.4
+go 1.24.9


The go directive should be a language version (major.minor) rather than a toolchain patch version. Using go 1.24.9 may be rejected by the Go toolchain; if you want to pin patch level, keep go 1.24 and add a toolchain go1.24.9 directive instead.

Suggested change

go 1.24.9

go 1.24

toolchain go1.24.9

phisco added 4 commits February 13, 2026 13:25

chore: align with function-template-go and sdk v0.5.0

cecaa71

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

refactor: migrate sdk deprecated extra_resources usage

1581410

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

chore: declare function capabilities in package metadata

a3e869c

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

refactor: simplify sort casting helper and fix lint formatting

fc8d3c9

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

phisco force-pushed the crossplane-v2 branch from ded8988 to fc8d3c9 Compare February 13, 2026 12:25

phisco requested a review from Copilot February 13, 2026 14:26

Copilot started reviewing on behalf of phisco February 13, 2026 14:26 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump to crossplane v2#98

Bump to crossplane v2#98
phisco wants to merge 4 commits intocrossplane-contrib:mainfrom
phisco:crossplane-v2

phisco commented Feb 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	response.Fatal(rsp, errors.Wrapf(err, "cannot get Function input from %T", req))
	response.Fatal(rsp, errors.Wrapf(err, "cannot get required resources from %T", req))

		@@ -203,24 +205,24 @@ func processSourceByReference(in *v1beta1.Input, config v1beta1.EnvironmentSourc
		return nil, errors.Errorf("Required environment config %q not found", envConfigName)

	return false, errors.Errorf("unsupported type %q for sorting", kind)
	return false, errors.Errorf("unsupported type %v for sorting", kind)

-      - build
+      - build
+    permissions:
+      contents: read
+      packages: write

Conversation

phisco commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of your changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

phisco commented Feb 13, 2026 •

edited

Loading