fix: skip null output documents#375
Merged
Peefy merged 1 commit intocrossplane-contrib:mainfrom Mar 15, 2026
Merged
Conversation
vlada-dudr
force-pushed
the
fix/prevent-null-crash
branch
from
ebe3277 to
651884d
Compare
Otherwise function panics and crashes. Signed-off-by: Vladimír Dudr <dudr@metrans.cz>
vlada-dudr
force-pushed
the
fix/prevent-null-crash
branch
from
651884d to
87c98ea
Compare
Collaborator
|
Thnak you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This little patch fixes condition when kcl program returns null document. If not handled function panics and crashes. This patch solves the issue by just skipping such documents.
Maybe it is more desirable to error out instead of skipping?
I have: