feat(claimtoxr): add Options API with Name and UID#122
Merged
tampakrap merged 1 commit intoMay 9, 2026
Conversation
Replace ConvertClaimToXR's args with an Options struct, adding two new
ones:
- Name: explicit XR name, overrides the direct-mode default (Claim name)
or the non-direct random suffix
- GenerateUID: set `metadata.uid` via `uuid.NewUUID()`
Existing Kind and Direct arguments are unchanged. The runner's call site
uses Options{} (without values) matching the previous behavior.
Also, the function now reutnrs `*composite.Unstructured` rather thant
`*unstructured.Unstructured`, since the produced object is conceptually
a Composite Resource. YAML/JSON marshaling continues to work via the
embedded `unstructured.Unstructured`.
The `xprin-helpers convert-claim-to-xr` command exposes the new options
as `--name` and `--gen-uid` flags. Documentation is updated accordingly.
Signed-off-by: Theo Chatzimichos <tampakrap@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace ConvertClaimToXR's args with an Options struct, adding two new ones:
metadata.uidviauuid.NewUUID()Existing Kind and Direct arguments are unchanged. The runner's call site uses Options{} (without values) matching the previous behavior.
Also, the function now reutnrs
*composite.Unstructuredrather thant*unstructured.Unstructured, since the produced object is conceptually a Composite Resource. YAML/JSON marshaling continues to work via the embeddedunstructured.Unstructured.The
xprin-helpers convert-claim-to-xrcommand exposes the new options as--nameand--gen-uidflags. Documentation is updated accordingly.