fix: validate paths and file types in showStudypad and showImage URL actions#1328
Merged
karlkleinpaste merged 1 commit intoJun 19, 2026
Merged
Conversation
…actions showStudypad passed the 'value' parameter directly to editor_create_new() as a file path without validation, enabling arbitrary file reads via path traversal or absolute paths. Add checks to reject '..', absolute paths, and directory separators. showImage passed the path to show_separate_image() which spawned xdg-open with the file as argument, enabling arbitrary file execution. Add a whitelist of recognized image file extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
showStudypad passed the 'value' URL parameter directly to
editor_create_new() as a file path without validation. Any local
process on the D-Bus session bus could trigger a path traversal
attack (e.g. "../../etc/passwd") to read arbitrary files.
showImage stripped the "file:" prefix and handed the path to
show_separate_image(), which spawns xdg-open -- any file type
could be opened in its default handler.
Fix showStudypad by rejecting paths containing "..", absolute paths
(g_path_is_absolute), and directory separators -- only bare
filenames pass through.
Fix showImage by whitelisting recognized image extensions: .png,
.jpg, .jpeg, .gif, .bmp, .svg, .tiff, .webp.