Skip to content

fix: escape HTML content before embedding in JavaScript string in editor_insert_html #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karlkleinpaste merged 1 commit into from
Jun 19, 2026
Merged

fix: escape HTML content before embedding in JavaScript string in editor_insert_html #1329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/editor/editor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,18 @@ void editor_execute_script(gchar *script, EDITOR *e)

void editor_insert_html(const gchar *html, EDITOR *e)
{
gchar *str = g_strdup_printf("document.execCommand('insertHTML', null, \'%s\');", html);
/* The HTML is embedded into a JavaScript string literal that is then
executed. g_strescape() escapes backslashes and double quotes (and
control characters), so embed the result inside a *double*-quoted JS
string. Note: g_strescape() does NOT escape single quotes, so the
string literal below must not be single-quoted, or a single quote in
the input would break out and allow script injection. */
gchar *escaped = g_strescape(html, NULL);
gchar *str = g_strdup_printf("document.execCommand('insertHTML', null, \"%s\");", escaped);
XI_message(("script: %s", str));
editor_execute_script(str, e);
g_free(str);
g_free(escaped);
}

/*
Expand Down