fix: escape ampersand and apostrophe in annotation content to prevent stored XSS#1330
Merged
karlkleinpaste merged 1 commit intoJun 19, 2026
Merged
Conversation
… stored XSS The annotation rendering code only replaced <, >, \n, and " with HTML entities. The ampersand was not escaped, enabling an entity encoding bypass: an attacker could enter e.g. &crosswire#60; which libxml2 would store as &crosswire#60; and decode back to &crosswire#60; on retrieval, allowing arbitrary HTML injection. Add & (must be first to prevent double-encoding) and apostrophe for defense in depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The annotation rendering code only replaced <, >, \n, and " with HTML
entities. The ampersand was not escaped, enabling an entity encoding
bypass: an attacker could enter e.g. < which libxml2 would store
as < and decode back to < on retrieval, allowing arbitrary
HTML injection.
Add & (must be first to prevent double-encoding of < etc.) and
' to the replacement list. NUM_REPLACE goes from 4 to 6.