Reject malformed passagestudy URLs#1333
Merged
karlkleinpaste merged 1 commit intoJun 23, 2026
Merged
Conversation
Validate passagestudy.jsp action parameters before dispatching them. This prevents malformed D-Bus setCurrentReference input from reaching strcmp or action handlers with null parameters.
Contributor
|
Again, much appreciation for your analysis and fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed
passagestudy.jspURLs can reachmain_url_handler()from remote-control paths such as D-Bus. If required query parameters are missing, the dispatcher can pass null values tostrcmp()or action handlers.This change validates the action and required parameters before dispatch, returns failure for malformed action URLs, and avoids dereferencing a missing module entry for user-note previews.