Skip to content

Fixed the bug that base block cannot be placed at minimum height. #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WMGameLive wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed the bug that base block cannot be placed at minimum height. #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/net/croxis/plugins/lift/BukkitElevatorManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,10 @@ public static BukkitElevator createLift(Block block, String cause){
plugin.logDebug("Starting elevator gen caused by: " + cause + " v" + plugin.getDescription().getVersion());
BukkitElevator bukkitElevator = new BukkitElevator(plugin);
bukkitElevator.cause = "Starting elevator gen caused by: " + cause + " v" + plugin.getDescription().getVersion();
int yscan = block.getY() - 1;
int yscan = block.getY();
while(yscan >= block.getWorld().getMinHeight()){
if (yscan == block.getWorld().getMinHeight()){ //Gone too far with no base abort!
yscan--;
if (yscan < block.getWorld().getMinHeight()){ //Gone too far with no base abort!
plugin.logDebug("No elevator base found");
bukkitElevator.setFailReason("No elevator base found");
return null;
Expand All @@ -90,7 +91,6 @@ public static BukkitElevator createLift(Block block, String cause){
plugin.logDebug("Is Base Block: " + BukkitElevatorManager.isBaseBlock(checkBlock));
return null;
}
yscan--;
}
plugin.logDebug("Base size: " + bukkitElevator.baseBlocks.size() + " at " + bukkitElevator.baseBlocks.iterator().next().getLocation().toString());

Expand Down