fix(persistence): Harden Windows file moves and variant logging#1083
Merged
fix(persistence): Harden Windows file moves and variant logging#1083
Conversation
- move node/opennet backup replace after stream close and check move result - add bounded replace-existing retry/backoff in FileUtil.moveTo() - improve ClientLayerPersister variant-aware unreadable-file diagnostics - add focused tests for move retry behavior and unreadable variant classification
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileUtil.moveTo(..., REPLACE_EXISTING)fallback to handle transient Windows sharing violations.ClientLayerPersistervariant-load diagnostics with explicit file-path/context logging and unreadable-variant classification.FileUtil.moveTo(File, File)by extracting atomic-move and retry helpers while preserving behavior.How to test
./gradlew test --tests 'network.crypta.support.io.FileUtilTest'./gradlew test --tests 'network.crypta.client.async.ClientLayerPersisterTest'./gradlew test --tests 'network.crypta.node.NodeIPDetectorTest' --tests 'network.crypta.node.NodeARKInserterTest' --tests 'network.crypta.node.OpennetManagerTest'./gradlew testNotes
release/2per request (current branch at invocation time).