This repository was archived by the owner on Feb 24, 2023. It is now read-only.
Open
Conversation
Contributor
Author
|
mrthankyou
reviewed
Jul 17, 2021
| @@ -0,0 +1,37 @@ | |||
| ## State variable shadowing | |||
There was a problem hiding this comment.
There is no link to this document in the main README.md.
mrthankyou
reviewed
Jul 17, 2021
| @@ -0,0 +1,21 @@ | |||
| ## Incorrect erc20 interface | |||
There was a problem hiding this comment.
I don't know if this makes sense but should there be a generalized rule that all interfaces should be correctly configured to return the correct value? This same type of bug could occur in cases where a developer uses a custom or non ERC-20/721 interface?
0xicingdeath
pushed a commit
that referenced
this pull request
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.