-
Notifications
You must be signed in to change notification settings - Fork 0
HTTP Streams #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
HTTP Streams #91
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
575e589
build: Add sse-starlette to dependencies
michael-pisman e6f3a84
feat: Add streaming endpoint and generator skeleton
michael-pisman 9dc8abb
feat: Add streams router to main router
michael-pisman 07d200c
fix: response class in event_log endpoint
michael-pisman ace1970
refactor: Update update_generator function signature
michael-pisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| from fastapi import APIRouter | ||
| from sse_starlette.sse import EventSourceResponse | ||
| from unipoll_api.utils.streams import update_generator | ||
|
|
||
|
|
||
| router = APIRouter() | ||
|
|
||
|
|
||
| @router.get("/updates", | ||
| response_class=EventSourceResponse) | ||
| async def event_log(): | ||
| updates = update_generator() | ||
| return EventSourceResponse(updates) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||
| import asyncio | ||||||
| from unipoll_api.documents import Resource | ||||||
| from . import colored_dbg as Debug | ||||||
|
|
||||||
|
|
||||||
| # async def update_generator(resource: Resource): | ||||||
| async def update_generator(): | ||||||
| i = 0 | ||||||
| try: | ||||||
| while True: | ||||||
| i += 1 | ||||||
| yield dict(data=i) | ||||||
| await asyncio.sleep(0.2) | ||||||
|
||||||
| await asyncio.sleep(0.2) | |
| await asyncio.sleep(SLEEP_DURATION) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commented-out code should be removed if it's not needed, or properly implemented if it represents the intended functionality with Resource parameter.