This repository was archived by the owner on Feb 25, 2022. It is now read-only.
Chore/improve coverage#381
Open
Ascenio wants to merge 12 commits into
Open
Conversation
Because vscode test runner doesn't like it. xD
|
Since this package has been moved to https://github.com/flutter/packages/tree/main/packages/go_router Can you create a pull request against the flutter/packages instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This PR adds new tests, reaching code paths not previously covered as pointed by a coverage report.
All tests are currently passing and result in
64.8%coverage.🆕 What is the new behavior (if this is a feature change)?
All tests are currently passing and result in
92.9%coverage.💥 Does this PR introduce a breaking change?
No. It does not change any
lib/file.🐛 Recommendations for testing
If you want to see the coverage report I mentioned before you could use genhtml tool. Just run the following:
📝 Links to relevant issues/docs
None.
🤔 Checklist before submitting
master.