Adds cross-browser support for entering dates#294
Draft
craigfowler wants to merge 19 commits intomasterfrom
Draft
Adds cross-browser support for entering dates#294craigfowler wants to merge 19 commits intomasterfrom
craigfowler wants to merge 19 commits intomasterfrom
Conversation
This might also need some tidy-up!
Due to issues in the Extensions package beta 4, this wasn't going to work. Those are now resolved.
Using the options pattern with a higher version of MSDI, this logic is no longer required.
At the moment, GitHub actions can run this workflow in parallel. That's not good though because Browserstack is a limited resource. If I try to have too many running at once, I get queue/timeout issues. This should fix that.
This tidies up and condenses the logic for following the options pattern when using Reqnroll. It's not a perfect implementation because of the adapters used, but it still provides enough that I can use the pattern in the desired use-cases.
If I'm right, this will fix the remainder of my cross-browser tests.
This marks the last of the old content which was worth keeping. I added a couple of tests into the v2 project, to account for a scenario in which it was worth testing. Otherwise, all of the old content is now gone.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily, this will resolve #281.
There's also work in here which should resolve #293 and #292.