Don't use Dataset.data_vars to access DataArrays in UGrid#188
Merged
Conversation
Dataset.data_vars doesn't contain any coordinate variables, so looking
for the node_x / node_y variables in there could lead to problems.
Unfortunately, iterating over Dataset.variables will return Variable
instances not DataArray instances. The best way to iterate all
DataArrays - be they coordinates or data - is to iterate as so:
data_arrays = (dataset[name] for name in dataset.variables.keys())
for data_array in data_arrays:
...
mx-moth
force-pushed
the
159-ugrid-data-vars
branch
from
9d3eba8 to
a254f86
Compare
david-sh-csiro
approved these changes
Aug 19, 2025
Collaborator
david-sh-csiro
left a comment
david-sh-csiro
left a comment
There was a problem hiding this comment.
Works locally and tests pass!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataset.data_vars doesn't contain any coordinate variables, so looking for the node_x / node_y variables in there could lead to problems.
Unfortunately, iterating over Dataset.variables will return Variable instances not DataArray instances. The best way to iterate all DataArrays - be they coordinates or data - is to iterate as so:
Fixes #159