Merged
Conversation
mx-moth
force-pushed
the
geometry-rewrite
branch
6 times, most recently
from
d68376d to
9f1dd79
Compare
Contributor
Author
|
Before release I definitely need to do a proper once over of the docs and comments and what not. I suspect there are references to |
mx-moth
force-pushed
the
geometry-rewrite
branch
3 times, most recently
from
b6ebf3f to
0c98384
Compare
mx-moth
force-pushed
the
geometry-rewrite
branch
2 times, most recently
from
e7df363 to
fceda56
Compare
It was only used in one location, and not used much at that. This is backwards incompatible, but not for something important.
This means that users can check the geometry type before building the geometry, which can help with resource usage in some cases.
It needed more detail than normal so I added a larger block above the changelog
mx-moth
force-pushed
the
geometry-rewrite
branch
from
fceda56 to
707613d
Compare
* origin/main: Fix mypy typing for _requires_plot() Fix release note PR link
I don't know why it is complaining but this seems to keep mypy happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewrites all the geometry handling to no longer make Polygons the default assumption. All kinds of grids are now on equal footing. This has some pretty big ramifications for plotting, which has been revamped along the way.
This is almost 100% backwards compatible with methods that adapt the old behaviour. These can be deprecated over time.
Closes #189, closes #121, closes #187, partially implements #175.