QA: Dependencies for Voucher Label Report - #454
Open
mikejritter wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds batik-all and barcode4j as dependencies to the reports/service module
Why are we doing this? (with JIRA link)
No Jira. This is a QA issue which was raised during testing of the UCB Voucher Label report.
These dependencies bring in a similar set to those found under
services/report/3rdparty/jasper-cs-report/src/main/resources/tenants/ucbg/nuxeo-server-lib, e.g.It's likely we could omit a number of the transitive dependencies, but I've made no attempt to do so.
How should this be tested? Do these changes have associated tests?
Before rebuilding CollectionSpace, make sure that your ucbg nuxeo database has the following types and functions:
If you're missing either of these, the voucher label type can be added with the following DDL:
The
findvoucherlabelsfunction exists inservices/common/src/main/resources/db/postgresql/tenants/ucbg/fnc-public-findvoucherlabels-nuxeo_botgarden.sqland can be loaded withIn addition, the voucher label report must exist in your collection space. If it does not exist, it can be added by issuing a
POSTtocspace-services/reportsusing the XML found inservices/report/3rdparty/jasper-cs-report/src/main/resources/tenants/ucbg/payloads/ucbgVoucherLabel.xml.Once these exist, you can test by doing the following:
Label requestedmust beyes, andNumber of sheetsmust be greater than 0. I also filled out the collector, horticulture/wild, voucher date, voucher collection number, and garden location fields.Voucher Labelreport.Dependencies for merging? Releasing to production?
None
Has the application documentation been updated for these changes?
I might update the comment in the pom.xml so that it explains why the dependencies are being brought in.
Did someone actually run this code to verify it works?
@mikejritter tested locally