Move the workflow actions off deprecated Node 20 - #104
Merged
Merged
Conversation
The 1.5.0 release run warned on every job that actions/checkout@v4 targets Node 20 and was being forced onto Node 24. Forced, so nothing failed - but only until the forcing stops. checkout goes v4 -> v7 and upload-artifact v4 -> v7, both at their current major. The version that fixes it is not the obvious one for upload-artifact. checkout moved to Node 24 in v5, but upload-artifact's v5 only had preliminary support and still ran on Node 20 by default; v6 is where it actually moved. So "bump everything to v5" would have left one of the two still deprecated, and still not warning about it, since GitHub flagged only checkout in that run. Going to the current major rather than the minimum that fixes it. What changed in between is credential handling and an ESM upgrade in checkout, an optional archive parameter in upload-artifact, and v7 blocking fork checkouts for pull_request_target and workflow_run - triggers neither workflow uses. Nothing that touches how these are called here, and it buys the longest run before the next deprecation. Both submodules: recursive options are untouched. They are what stop the reactor building green and shipping jmsfx-server without the brand stylesheet, since Maven skips a missing resource directory with only a warning. Left alone deliberately: setup-java stays on v5, which #66 moved it to and which already targets Node 24 - v6 exists but there is nothing to fix. ncipollo's release-action@v1 is already node24 too. These majors require a minimum runner version. Immaterial on GitHub-hosted runners, which are kept current, but it would matter to a self-hosted one. Closes #101 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101.
The 1.5.0 release run warned on every job:
Forced, so nothing fails today — until the forcing stops.
actions/checkoutactions/upload-artifactactions/setup-javancipollo/release-actionThe version that fixes it is not the obvious one
checkoutmoved to Node 24 in v5, butupload-artifact's v5 still runs on Node 20 — its release notes say v5 had "preliminary support" and the runtime only actually moved in v6.So the obvious reading of the issue — bump everything to v5 — would have left
upload-artifactstill on the deprecated runtime, and still not warning about it, since GitHub flagged onlycheckoutin that run. Worth knowing when the same fix gets applied to the repositories #102 creates.Why the current major rather than the minimum
What changed in between is credential handling and an ESM upgrade in
checkout, an optionalarchiveparameter inupload-artifact, and v7 blocking fork checkouts forpull_request_targetandworkflow_run— triggers neither workflow uses. Nothing that touches how they are called here, and it buys the longest run before the next deprecation.Care taken
Both
submodules: recursiveoptions are untouched. They are what stop the reactor building green and shippingjmsfx-serverwithout the brand stylesheet, since Maven skips a missing resource directory with only a warning.These majors require a minimum Actions runner version. Immaterial on GitHub-hosted runners, which are kept current, but it would matter to a self-hosted one.
Verification
maven.ymlruns on pull requests to master, so this PR exercisescheckout@v7on its own.release.yml's two checkouts and the artifact upload need aworkflow_dispatchrun against this branch — happy to trigger one, or it can wait for the 2.0.0 tag, since the manual path leaves the bundles as artifacts without touching a release.🤖 Generated with Claude Code