Stop jmsfx-hallux depending on jmsfx-creator - #109
Merged
Merged
Conversation
A library depending on a desktop application, runtime and optional, so that IconCreator could be run against the hallux library. That is a developer convenience, not something a consumer of the published jar has any use for - and #76 made it unnecessary anyway, since IconCreator discovers whichever library is on its classpath rather than naming one. Invisible while every module shares a version. Once jmsfx-viewer has a lifecycle of its own it would put the applications' version into a library's pom, and anyone resolving jmsfx-hallux would see an optional dependency on a desktop app. Runtime scope, so nothing compiled against it and the build is unaffected. Running IconCreator against this library is now what it is for every other library: put both on the classpath. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for #102.
jmsfx-halluxdeclared aruntime,optionaldependency onjmsfx-creator— a library depending on a desktop application — so that IconCreator could be run against the hallux library. That is a developer convenience rather than anything a consumer of the published jar needs, and #76 made it unnecessary regardless: IconCreator discovers whichever library is on its classpath instead of naming one.It is invisible today because every module shares a version. Once
jmsfx-viewerhas a lifecycle of its own it would put the applications' version into a library's pom, and anyone resolvingjmsfx-halluxfrom Central would see an optional dependency on a desktop application.runtimescope, so nothing compiled against it.mvn verifygreen. Running IconCreator against this library is now what it is for any other: put both on the classpath.🤖 Generated with Claude Code