Fix the issue of using '_flinalg' in NFINDR#15
Fix the issue of using '_flinalg' in NFINDR#15rguliev wants to merge 1 commit intoctherien:masterfrom
Conversation
Fixes ctherien#14 From scipy 13.0 on, `sp.linalg._flinalg` is not available. Which is fine, because it's not meant to be used directly:) This pull request replaces `sp.linalg._flinalg` determinant function with `sp.linalg.det` to fix error. Might become a slower, I haven't checked the performance. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/ctherien/pysptools/issues/14?shareId=XXXX-XXXX-XXXX-XXXX).
|
Quick question just for clarification, when that returns it returns a scalar (hence the determinant aspect) why is the value still have the [0] following it? Including that didn't allow my test to run. Thank you! |
|
It was a hack, not a good idea
Le ven. 27 mars 2026 à 14:38, sputnik2481 ***@***.***> a
écrit :
… *sputnik2481* left a comment (ctherien/pysptools#15)
<#15?email_source=notifications&email_token=AEBAWNJQ2YWHH5SUW4HSV4D4S3DB7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGQ2TCNJUGY42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS2XA4S7MNXW23LFNZ2F633QMVXF6Y3MNFRWW#issuecomment-4144515469>
Quick question just for clarification, when that returns it returns a
scalar (hence the determinant aspect) why is the value still have the [0]
following it? Including that didn't allow my test to run.
Thank you!
—
Reply to this email directly, view it on GitHub
<#15?email_source=notifications&email_token=AEBAWNJQ2YWHH5SUW4HSV4D4S3DB7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGQ2TCNJUGY42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS2XA4S7MNXW23LFNZ2F633QMVXF6Y3MNFRWW#issuecomment-4144515469>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEBAWNI3VINAVQEBAWQEIAD4S3DB7AVCNFSM6AAAAACXCMNG4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNBUGUYTKNBWHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
And for the return, frankly I don't remember
Le dim. 29 mars 2026 à 19:04, Christian Thérien ***@***.***>
a écrit :
… It was a hack, not a good idea
Le ven. 27 mars 2026 à 14:38, sputnik2481 ***@***.***> a
écrit :
> *sputnik2481* left a comment (ctherien/pysptools#15)
> <#15?email_source=notifications&email_token=AEBAWNJQ2YWHH5SUW4HSV4D4S3DB7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGQ2TCNJUGY42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS2XA4S7MNXW23LFNZ2F633QMVXF6Y3MNFRWW#issuecomment-4144515469>
>
> Quick question just for clarification, when that returns it returns a
> scalar (hence the determinant aspect) why is the value still have the [0]
> following it? Including that didn't allow my test to run.
>
> Thank you!
>
> —
> Reply to this email directly, view it on GitHub
> <#15?email_source=notifications&email_token=AEBAWNJQ2YWHH5SUW4HSV4D4S3DB7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGQ2TCNJUGY42M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS2XA4S7MNXW23LFNZ2F633QMVXF6Y3MNFRWW#issuecomment-4144515469>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEBAWNI3VINAVQEBAWQEIAD4S3DB7AVCNFSM6AAAAACXCMNG4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNBUGUYTKNBWHE>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
Yes that's what I thought, as this function returns a singleton value eg a scalar so putting the [0] after it will always throw an error because that's the wrong object type. To fix this you must remove the [0] after as it does not have an index because its just a singleton integer value. |
3 participants
Fixes #14
From scipy 13.0 on,
sp.linalg._flinalgis not available.Which is fine, because it's not meant to be used directly:)
This pull request replaces
sp.linalg._flinalgdeterminant function withsp.linalg.detto fix error. Might become a slower, I haven't checked the performance.For more details, open the Copilot Workspace session.