Skip to content

do not let user overwrite output_dir but break instead #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TjarkMiener merged 1 commit into from
Sep 19, 2025
Merged

do not let user overwrite output_dir but break instead #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 5 additions & 26 deletions ctlearn/tools/train_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,6 @@ class TrainCTLearnModel(Tool):
).tag(config=True)


overwrite = Bool(help="Overwrite output dir if it exists").tag(config=True)

aliases = {
"signal": "TrainCTLearnModel.input_dir_signal",
"background": "TrainCTLearnModel.input_dir_background",
Expand All @@ -239,33 +237,14 @@ class TrainCTLearnModel(Tool):
("o", "output"): "TrainCTLearnModel.output_dir",
}

flags = {
"overwrite": (
{"TrainCTLearnModel": {"overwrite": True}},
"Overwrite existing files",
),
}

classes = (
[
CTLearnModel,
DLDataReader,
]
+ classes_with_traits(CTLearnModel)
+ classes_with_traits(DLDataReader)
)
classes = classes_with_traits(CTLearnModel) + classes_with_traits(DLDataReader)

def setup(self):
# Check if the output directory exists and if it should be overwritten
# Check if the output directory exists
if self.output_dir.exists():
if not self.overwrite:
raise ToolConfigurationError(
f"Output directory {self.output_dir} already exists. Use --overwrite to overwrite."
)
else:
# Remove the output directory if it exists
self.log.info("Removing existing output directory %s", self.output_dir)
shutil.rmtree(self.output_dir)
raise ToolConfigurationError(
f"Output directory {self.output_dir} already exists."
)
# Create a MirroredStrategy.
self.strategy = tf.distribute.MirroredStrategy()
atexit.register(self.strategy._extended._collective_ops._lock.locked) # type: ignore
Expand Down