Fix: Issue 259 - Modify condition of naming for last layer#260
Merged
TjarkMiener merged 1 commit intoOct 17, 2025
Merged
Conversation
TjarkMiener
approved these changes
Oct 17, 2025
Member
TjarkMiener
left a comment
TjarkMiener
left a comment
There was a problem hiding this comment.
Thanks for the bug fix @hugo-varenne!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution to the prediction of classification model (particle type) error (#259). This occurs when using LoadedModel or SimpleCNN subclass of CTLearnModel. This is due to a naming behaviour where the last layer name was expecting to finish with "_softmax". With LoadedModel and SimpleCNN, the naming wasn't working as expected, so in order to be more flexible, the condition changed from looking at the last layer name to looking at the type of layer (softmax for classification task)