Skip to content

Fix build on Windows/MSVC#1

Open
aleokdev wants to merge 1 commit into
ctu-mrs:masterfrom
aleokdev:fix-msvc-build
Open

Fix build on Windows/MSVC#1
aleokdev wants to merge 1 commit into
ctu-mrs:masterfrom
aleokdev:fix-msvc-build

Conversation

@aleokdev
Copy link
Copy Markdown

A couple of fixes for building in MSVC:

  • Add math.h includes where M_PI constants are used, with the _USE_MATH_DEFINES compile definition
  • Use target_compile_options instead of add_compile_definitions so that warnings on the yaml library don't affect the executable compilation
  • Use FetchContent instead of find_package so that users don't need to have the yaml package installed
  • Fix some conversions and warnings
  • Avoid the usage of alternative operators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant