Update GitHub Actions, PyPI Configuration and Add Codecov Token#168
Update GitHub Actions, PyPI Configuration and Add Codecov Token#168
Conversation
WalkthroughThe pull request includes updates to two GitHub Actions workflow files: In the In the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
.github/workflows/release.yml (1)
11-14: Consider updating Python version.The workflow uses Python 3.8 which, while still supported, is not the latest stable version. Consider updating to Python 3.11 or 3.12 for improved performance and features.
- python-version: 3.8 + python-version: "3.12"🧰 Tools
🪛 actionlint (1.7.4)
11-11: the runner of "actions/setup-python@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/test.yml (3)
Line range hint
8-10: Update GitHub Actions versions for consistency.The workflow uses outdated versions of actions. For consistency with the release workflow and to benefit from the latest features and security fixes:
- uses: actions/checkout@v2 + uses: actions/checkout@v4 - uses: actions/setup-python@v2.2.1 + uses: actions/setup-python@v4Also, replace
actions/checkout@masterwithactions/checkout@v4to avoid using floating refs.Also applies to: 22-24, 31-33
🧰 Tools
🪛 yamllint (1.35.1)
[error] 54-54: no new line character at the end of file
(new-line-at-end-of-file)
Line range hint
19-20: Update Python versions in test matrix.Python 3.7 reached end-of-life on June 27, 2023. Consider updating the test matrix to modern Python versions:
strategy: matrix: - python-version: [3.7, 3.8] + python-version: ["3.9", "3.10", "3.11", "3.12"]🧰 Tools
🪛 yamllint (1.35.1)
[error] 54-54: no new line character at the end of file
(new-line-at-end-of-file)
54-54: Add newline at end of file.Add a newline character at the end of the file to comply with POSIX standards.
🧰 Tools
🪛 yamllint (1.35.1)
[error] 54-54: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
.github/workflows/release.yml(2 hunks).github/workflows/test.yml(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/test.yml
[error] 54-54: no new line character at the end of file
(new-line-at-end-of-file)
🪛 actionlint (1.7.4)
.github/workflows/release.yml
11-11: the runner of "actions/setup-python@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🔇 Additional comments (3)
.github/workflows/release.yml (2)
9-9: LGTM! Good practice using fixed versions instead of floating refs.
The updates to use specific versions (v4 and release/v1) instead of floating refs (master) improve workflow stability and predictability.
Also applies to: 11-11, 20-20
23-23: LGTM! Improved secret naming convention.
The change from pypi_password to PYPI_API_TOKEN better reflects the token's purpose and follows naming conventions.
.github/workflows/test.yml (1)
54-54: LGTM! Added Codecov authentication token.
The addition of the Codecov token improves security by authenticating coverage report uploads.
🧰 Tools
🪛 yamllint (1.35.1)
[error] 54-54: no new line character at the end of file
(new-line-at-end-of-file)
gmorales96
requested review from
felipao-mx,
mike-one,
pachCode and
rogelioLpz
3 participants
Context:
This PR updates the GitHub Actions configuration to use a PyPI API token. Additionally, the versions of the GitHub Actions used in the workflow are updated. The
codecov_tokenis also added for integration with Codecov, which will allow better tracking of code coverage.Changes Made:
codecov_tokenfor code coverage with Codecov.Files Modified:
.github/workflows/test.yml(integratedcodecov_tokenand updated actions)..github/workflows/release.yml(modified to use the PyPI token).Tests:
Summary by CodeRabbit