-
Notifications
You must be signed in to change notification settings - Fork 131
Tool guard #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
naamaz
wants to merge
6
commits into
cuga-project:main
Choose a base branch
from
naamaz:tool_guard
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tool guard #302
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -177,6 +177,14 @@ async def _generate_policy_embedding(self, policy: Policy) -> List[float]: | |
| text_parts.append(policy.guide_content[:300]) | ||
| if policy.target_tools and "*" not in policy.target_tools: | ||
| text_parts.append(f"Tools: {', '.join(policy.target_tools[:10])}") | ||
| if policy.tool_guards: | ||
| # Add tool guard information to search text | ||
| for tool_name, guard in policy.tool_guards.items(): | ||
| text_parts.append(f"Guard for {tool_name}") | ||
| if guard.violating_examples: | ||
| text_parts.append(f"Violations: {' '.join(guard.violating_examples[:3])}") | ||
| if guard.compliance_examples: | ||
| text_parts.append(f"Compliance: {' '.join(guard.compliance_examples[:3])}") | ||
|
Comment on lines
+185
to
+187
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cap tool-guard example text before embedding. Lines 185-187 concatenate raw examples with no length bound. Large examples can blow embedding input limits and fail policy writes. Proposed fix if policy.tool_guards:
# Add tool guard information to search text
+ max_example_chars = 200
for tool_name, guard in policy.tool_guards.items():
text_parts.append(f"Guard for {tool_name}")
if guard.violating_examples:
- text_parts.append(f"Violations: {' '.join(guard.violating_examples[:3])}")
+ violations = " ".join(
+ ex[:max_example_chars] for ex in guard.violating_examples[:3]
+ )
+ text_parts.append(f"Violations: {violations}")
if guard.compliance_examples:
- text_parts.append(f"Compliance: {' '.join(guard.compliance_examples[:3])}")
+ compliance = " ".join(
+ ex[:max_example_chars] for ex in guard.compliance_examples[:3]
+ )
+ text_parts.append(f"Compliance: {compliance}")🤖 Prompt for AI Agents |
||
|
|
||
| elif isinstance(policy, OutputFormatter): | ||
| # OutputFormatter-specific content | ||
|
|
||
3 changes: 3 additions & 0 deletions
3
src/cuga/backend/cuga_graph/policy/tool_guard/tests/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| """Tests for tool guard policies.""" | ||
|
|
||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fail fast on malformed
tool_guardsfrontmatter.At Line 216, a non-dict
tool_guardsvalue is silently ignored, which can accidentally disable intended guard enforcement. Reject invalid shapes explicitly instead of falling back toNone.Proposed fix
🤖 Prompt for AI Agents